Add a health check #146
Merged
Add a health check #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the current Gemstash environment in the Gemstash::Env::RackMiddleware, otherwise health checks could fail
Preserve newline fix from commit bc811ec in the pandoc generation
|
@smellsblue Is there anything else you want us to have for this to be a healthcheck endpoint? |
|
@olleolleolle I was hoping to get a review, but then got caught up in other work. If you are happy with what I've done, I can merge it now. I looked at the build failures, and I don't think they are related to my changes. |
|
@smellsblue I am quite happy with these changes! The build failures do look unrelated. LGTM! |
|
@smellsblue We've tried this on production and got this error randomly: Guessed some additional check needs to be performed before inserting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #145
The health endpoint is at
/healthand will check that reading and writing from storage is working.If you want a health endpoint that doesn't do any work, you can use
/health/heartbeat.The HTTP status code will indicate success vs failure (200 vs 500), and you will receive a JSON response that will indicate the breakdown of what succeeded vs failed.