-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[ParallelInstaller] Do not deadlock when the lockfile is missing dependencies entirely #5516
Conversation
nice work 👍 @bundlerbot r+ |
📌 Commit eefb983 has been approved by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to update existing tests
|
||
fatally_missing_specs = missing_dependencies.map(&:last).flatten.map(&:name) - @specs.map(&:name) | ||
return Bundler.ui.warning(warning) if fatally_missing_specs.empty? | ||
raise InstallError, warning.concat("\n\nBundler is unable to continue installing without #{fatal.join(",")} in the lockfile.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the proper var, fatally_missing_specs
…ndirect [ParallelInstaller] Do not deadlock when the lockfile is missing dependencies entirely Closes #5480
💔 Test failed - status-travis |
@segiddins ping |
I've not forgotten about this, just haven't come up with a good way to actually fix it yet 😔 |
Ping? Any updates on this? Still running into deadlocks unfortunately. 😢 In my case, removing |
I'll update this PR as soon as progress is made -- I haven't figured out how it should work yet. |
Facing the same problem right now. Do you have any on news on this? Thx & Cheers. EDIT: |
@zirni try bundler v1.15.0.pre.3 |
Closes #5480
Closes #5519