This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[CompactIndex] Disable when openssl is in fips mode #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course, Ruby < 2 doesn't have that constant |
Closed
| require "openssl" | ||
| return false if defined?(OpenSSL::OPENSSL_FIPS) && OpenSSL::OPENSSL_FIPS | ||
| rescue LoadError | ||
| nil |
There was a problem hiding this comment.
Do you want to return false in both cases for consistency?
|
@segiddins Validated that this change works properly on a system with FIPS enabled. As stated in #4989, it is a LOT slower when resolving dependencies but it does work correctly which should meet the requirements of anyone in a FIPS restricted environment. |
|
@segiddins Any update of getting this merged? |
|
@indirect r? |
|
@bundlerbot r+ |
|
📌 Commit 8075f8c has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Dec 15, 2016
[CompactIndex] Disable when openssl is in fips mode Should close #4989
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #4989