Fixes INT signal for ruby executables

[asutoshpalai]

Fixes #4568

[segiddins]

Signal.list is a hash, so could that be |signal, _|?

[asutoshpalai]

Yea! My bad!

[asutoshpalai]

Is it fine to include the spec file in exempt list of quality_spec for debug mechanism?
The sleep is firing it off.

The alternative to sleep is an infinite loop with the risk that if the specs fail we will be left with a running ruby process on our computer even after rspec exits.

[segiddins]

@asutoshpalai apply the following and add the magic comment at the end of the line with the sleep

diff --git a/spec/quality_spec.rb b/spec/quality_spec.rb
index d5178d7..57e737c 100644
--- a/spec/quality_spec.rb
+++ b/spec/quality_spec.rb
@@ -28,7 +28,9 @@ describe "The library itself" do

     failing_lines = []
     File.readlines(filename).each_with_index do |line, number|
-      failing_lines << number + 1 if line =~ debugging_mechanisms_regex
+      if line =~ debugging_mechanisms_regex && !line.end_with?("# ignore quality_spec")
+        failing_lines << number + 1
+      end
     end

     return if failing_lines.empty?

[segiddins]

@asutoshpalai this seems to break some stuff on 1.8.7

[asutoshpalai]

The variable arguments to yield are breaking some specs in 1.8.7. Will fix those specs with dummy arguments.

But the major problem is on 1.8.7 popen3 doesn't have any method to obtain the pid, which in turn means we can't send any signal to the process. So the new spec can't work on 1.8.7.

[segiddins]

that's fine, you can limit the spec to being ruby >= 1.9.3

[segiddins]

The spec needs a name

[segiddins]

👍 other than the one comment

[segiddins]

@homu r+

[homu]

📌 Commit 5fcd26d has been approved by segiddins

[homu]

⌛ Testing commit 5fcd26d with merge 99a9a15...

[homu]

☀️ Test successful - status