This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Checking out missing git repos (but not being installed) - Fixing #3981 #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asutoshpalai
changed the title
asutoshpalai
changed the title
asutoshpalai
changed the title
| @@ -14,5 +14,30 @@ | |||
| expect(out).to include("Using foo 1.0 from #{lib_path("foo")} (at master@#{revision_for(lib_path("foo"))[0..6]})") | |||
| should_be_installed "foo 1.0" | |||
| end | |||
|
|
|||
| it "should check out git repos that are missing but not being installed" do | |||
There was a problem hiding this comment.
could you please also test that the repo is being checked out?
There was a problem hiding this comment.
Is checking that the directory is present enough?
I added that.
|
@homu r+ |
|
📌 Commit b3a527f has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Mar 16, 2016
Checking out missing git repos (but not being installed) - Fixing #3981 Fixes #3981. As far as I investigated the problem is, being in `without` group, it is not marked in missing_spec and so it is not resolved while resolving specs at https://github.com/bundler/bundler/blob/master/lib/bundler/installer.rb#L183 and https://github.com/bundler/bundler/blob/master/lib/bundler/installer.rb#L195 but it is in the definition's index at https://github.com/bundler/bundler/blob/master/lib/bundler/definition.rb#L209 leading to https://github.com/bundler/bundler/blob/master/lib/bundler/source/git.rb#L150 where it checks for the presence of the folder at https://github.com/bundler/bundler/blob/master/lib/bundler/source/path.rb#L135 Possible solutions are : - add it to the list of missing_specs - check while building the index in Definition class and don't add it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3981.
As far as I investigated the problem is, being in
withoutgroup, it is not marked in missing_spec and so it is not resolved while resolving specs at https://github.com/bundler/bundler/blob/master/lib/bundler/installer.rb#L183and https://github.com/bundler/bundler/blob/master/lib/bundler/installer.rb#L195
but it is in the definition's index at
https://github.com/bundler/bundler/blob/master/lib/bundler/definition.rb#L209
leading to
https://github.com/bundler/bundler/blob/master/lib/bundler/source/git.rb#L150
where it checks for the presence of the folder at
https://github.com/bundler/bundler/blob/master/lib/bundler/source/path.rb#L135
Possible solutions are :