Lay groundwork for system specs #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solebared
commented
May 8, 2021
| @@ -1,51 +1,49 @@ | |||
| docker_image: &docker_image | |||
| image: circleci/ruby:2.7.2-node | |||
|
|
|||
There was a problem hiding this comment.
A lot of the changes in this file are slight renames of commands and jobs. The significant additions are the rspec_system command system_specs job.
svileshina
approved these changes
Jun 18, 2021
Also support switiching to headless_chrome based on env variable.
Also refactors .circleci/config.yml: - rename some commands, steps, jobs, workflows for consistency and to reduce ambiguity between the different types of elements - consolidatees all tmp files under /tmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We've been needing some system-level test coverage for a while now. This PR sets up the minimal groundwork needed to start writing them.
What
bin/rspecwill exclude all system specs; to run them, all requested specs must be system specs, egbin/rspec spec/system.Next Steps
With these changes, our
.circleci/config.ymlis in need of some refactoring; will follow up with a PR to address this.Outstanding Questions, Concerns and Other Notes
?
Pre-Merge Checklist