Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contributions restful and authorized #858

Merged
merged 4 commits into from
Feb 14, 2021
Merged

Conversation

solebared
Copy link
Collaborator

Why

Completes authorization changes to ContributionsController in preparation for re-opening registration.

What

  1. Removes unused combined_form action and view
  2. Extracts thank_you action into its own controller
  3. Change triage action to edit
  4. Change triage_update action to update
  5. Flesh out ContributionPolicy
  6. Authorize all actions in ContributionController (except index)

Next Steps

?

Outstanding Questions, Concerns and Other Notes

  • We should put a policy_scope around the index action but i ran out of time to do that.

Pre-Merge Checklist

  • All new features have been described in the pull request
  • Security & accessibility have been considered
  • High quality tests have been added, or an explanation has been given why the features cannot be tested
  • New features have been documented, and the code is understandable and well commented
  • Entry added to CHANGELOG.md if appropriate
  • All outstanding questions and concerns have been resolved
  • Any next steps that seem like good ideas have been created as issues for future discussion & implementation

@svileshina svileshina force-pushed the reworking-contributions-show-respond branch from cf24ca2 to 25a762b Compare February 14, 2021 17:08
@solebared solebared mentioned this pull request Feb 14, 2021
30 tasks
Base automatically changed from reworking-contributions-show-respond to main February 14, 2021 17:10
@solebared solebared merged commit 042cb6b into main Feb 14, 2021
@solebared solebared deleted the make-contributions-restful branch February 14, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants