Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open fully public controllers #841

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

solebared
Copy link
Collaborator

Why

As we consolidate our authorization solution, there are a handful of controllers that are fully public and don't need authentication or authorization. This is codified in PublicController

Pre-Merge Checklist

  • All new features have been described in the pull request
  • Security & accessibility have been considered
  • High quality tests have been added, or an explanation has been given why the features cannot be tested
  • New features have been documented, and the code is understandable and well commented
  • All outstanding questions and concerns have been resolved
  • Any next steps that seem like good ideas have been created as issues for future discussion & implementation

Next Steps

See #840.

And once we're done with this push, it could be useful to review where we've landed with:

  • Authorization concern
  • ApplicationController
  • AdminController
  • PublicController

Outstanding Questions, Concerns and Other Notes

?

@solebared solebared mentioned this pull request Jan 26, 2021
30 tasks
@solebared solebared merged commit c664880 into main Jan 26, 2021
@solebared solebared deleted the open-fully-public-controllers branch January 26, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants