Make admin controllers restful #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces AdminController#landing_page.
This page links to Forms, FormQuestions and CustomFormQuestions, all of which are accessible from the admin dashboard. It also doesn't seem to be linked from anywhere.
... into GlossaryController, and consolidate views. Note two important loose ends: 1. The edit/update actions need to be secured with pundit. 2. The current glossary was hardcoded in /glossary/show.html.erb. Since this commit changes that to be dynamic, we'll want to put the static contents into a seed file or similar.
This was referenced Jan 23, 2021
Merged
svileshina
force-pushed
the
make-admin-controllers-restful
branch
from
0b48cca
to
083b6ff
Compare
Conflicts: - app/controllers/admin_controller.rb
maebeale
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
AdminControllercurrently contains a handful of non-restful actions. In addition to their non-restfulness, they also make it hard to inherit fromAdminController(see related discussion in #835).Pre-Merge Checklist
What
When reviewing, probably easiest to look at each commit separately.
AdminDashboardController(2cbc8f0)VolunteerAdminController(0a23489)DispatchStepsController(8b6e91c)YearbookController(7c6cf57)/admin/formspage (1fb7777)GlossaryController(e5ae91f)GlossaryControllerpunditso that edit/update aren't publicly accessibleNext Steps
@svileshina is taking over this branch to finish out the remaining steps ^^. 🙌🏾
Outstanding Questions, Concerns and Other Notes
?
Security
Will need to ensure /glossary is correctly secured. All other extracted resources remain inaccessible w/o login.