Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename acting_user accessor in policies #834

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Rename acting_user accessor in policies #834

merged 2 commits into from
Mar 3, 2021

Commits on Feb 25, 2021

  1. Rename acting_user to user in policies 

    Definite tradeoffs in both directions but after a group discussion, felt
that new engineers having to investigate/learn another term wasn't worth
the benefits of the explicit qualification. Dropping back to the term
used in pundit docs/examples with the understanding that any _other_
users in play can be qualified as needed.
    @solebared
    solebared committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    76f8d53 View commit details
    Browse the repository at this point in the history

  2. Rename original_scope to scope 

    Doesn't feel like the qualification is necessary, falling back to the
term used in pundit docs/examples.
    @solebared
    solebared committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    4098a99 View commit details
    Browse the repository at this point in the history