Add fab class to fix whatsapp logo display #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahriffell
reviewed
Nov 17, 2020
solebared
reviewed
Dec 4, 2020
Co-authored-by: Leah Riffell <leah.riffell@gmail.com> Co-authored-by: Angela Guardia <47278429+AngelaGuardia@users.noreply.github.com> Co-authored-by: David Atkins <atki1080@gmail.com> Co-authored-by: Taylor Phillips <taylorscottphillips@gmail.com> Co-authored-by: Nathan Darrington <npdarrington@icloud.com> Co-authored-by: Eugene Theriault <hybridbassist@gmail.com> Co-authored-by: Will Dunlap <dunlapww@gmail.com>
Co-authored-by: Leah Riffell <34531014+leahriffell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Leah Riffell leah.riffell@gmail.com
Co-authored-by: Angela Guardia 47278429+AngelaGuardia@users.noreply.github.com
Co-authored-by: David Atkins atki1080@gmail.com
Co-authored-by: Taylor Phillips taylorscottphillips@gmail.com
Co-authored-by: Nathan Darrington npdarrington@icloud.com
Co-authored-by: Eugene Theriault hybridbassist@gmail.com
Co-authored-by: Will Dunlap dunlapww@gmail.com
Why
closes #391
Pre-Merge Checklist
Security & accessibility have been consideredNew features have been documented, and the code is understandable and well commentedEntry added to CHANGELOG.md if appropriateWhat
Add fab class to fix whatsapp logo display
Icon now works both on the Vue side (/contributions), and on the rails side (/contact_methods)
How
Font awesome requires fab class to display brand icons
Imported font awesome brand
Added fab class to the whatsapp icon of SingleIcon.vue and MappedIconList.vue
Testing
Added a test that whatsapp label exists and fab class exists
Outstanding Questions, Concerns and Other Notes