Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pagination for People #792

Merged
merged 5 commits into from
Oct 23, 2020
Merged

Add Pagination for People #792

merged 5 commits into from
Oct 23, 2020

Commits on Oct 20, 2020

  1. Add Pagination for People

    Closes rubyforgood#528
    
    Using the [`pagy`](https://ddnexus.github.io/pagy/how-to#quick-start) gem,
    add pagination to the `peoples_controller#index` route.
    
    Two modules have been included:
    
      1. `Pagy::Backend` in `ApplicationController`
      2. `Pagy::FrontEnd` in `ApplicationHelper`
    
    The navigation for `People` has been added to the `index` view and is
    present only when there are enough `People` to paginate. `pagy` takes
    care of all query parameters around pagination.
    
    For testing, I introduced a new folder for controller testing and added
    the `rails-controller-testing` gem to allow expectations via `assigns`.
    
    I was not sure of any front-end specific testing for this feature but am
    happy to create one if we need it.
    yez committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    3afc1e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Reduce includes Footprint

    Also use bulma renderer instead of normal
    yez committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    a468633 View commit details
    Browse the repository at this point in the history
  2. Remove Controller Spec and rails-controller-testing

    Add request spec
    yez committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    be47633 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Move from helper to concern

    yez committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    6896fc9 View commit details
    Browse the repository at this point in the history
  2. Update spec/requests/people_spec.rb

    Co-authored-by: lasitha <lasitharanatunga@learnzillion.com>
    yez and lasitha authored Oct 23, 2020
    Configuration menu
    Copy the full SHA
    90a4624 View commit details
    Browse the repository at this point in the history