642/create new ask from contributions

[metamoni]

Why

Resolves issue 642

Pre-Merge Checklist

• All new features have been described in the pull request
• Security & accessibility have been considered
• All outstanding questions and concerns have been resolved
• Any next steps that seem like good ideas have been created as issues for future discussion & implementation
• High quality tests have been added, or an explanation has been given why the features cannot be tested
• New features have been documented, and the code is understandable and well commented
• Entry added to CHANGELOG.md if appropriate

Does this need to be added to the CHANGELOG.md? If so, please let me know which version to add it to.

What

• Added Ask/Offer buttons to bottom of Contributions page

How

Seeing as the main purpose of this page is to view existing Asks/Offers, I've placed these actions at the bottom of the page. I also chose not to wrap them in a "card" class, as I wanted them to be easy to distinguish between all the other Ask/Offer cards. If you prefer this to look differently or be placed at the top of the page, let me know and I'll update the code.

Testing

Added test to confirm that the new section and buttons have been rendered on the page.

Next Steps

Accessibility: Across the entire app, the focus on the primary buttons has been either removed or overwritten. I tabbed through the page and couldn't really tell which buttons were focused. Consider either improving the current styles or removing them altogether (while they're usually not pretty, default focus styles are more accessible).

Outstanding Questions, Concerns and Other Notes

• If you think this needs to be added to the changelog please tell me which version I should add it to

Accessibility

Buttons are consistent with what's been used on the page so far. Users can access and trigger the newly added Ask/Offer buttons by keyboard. See 'Next steps' for more.

[solebared]

This looks great @metamoni! 🚀 🙌🏾 .
LGTM; one small comment about css.

[metamoni]

@exbinary should I add this to the Changelog? could add it to the [unreleased] bit for now.

[solebared]

@exbinary should I add this to the Changelog? could add it to the [unreleased] bit for now.

Sounds good to me. Thank you!

[metamoni]

All done now. Thanks!