Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test service #740

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Conversation

indiebrain
Copy link
Collaborator

@indiebrain indiebrain commented Sep 25, 2020

Why

In a docker development environment, the test are run using the app
service - IE the use the same "image" as the running application - via
bin/dev/test. This service is no longer needed.

Resolves #739

Pre-Merge Checklist

All these boxes should be checked off before any pull request is merged!

  • All new features have been described in the pull request
  • Security & accesibility have been considered
  • All outstanding questions and concerns have been resolved
  • Any next steps that seem like a good ideas have been created as issues for future discussion & implementation
  • High quality tests have been added, or an explanation has been given why the features cannot be tested
  • New features have been documented, and the code is understandable and well commented
  • Entry added to CHANGELOG.md if appropriate

How

bin/dev/test reuses the app service's image to spin up a container in which the tests are run. For rspec, the spec_helper already specifies that the application will run in the test environment, rather than the default.

Testing

bin/dev/test should still run the test suite

Next Steps

It might be nice to provide an interface to allow the developer to run a specific, or subset, of examples/specs in the test suite. I know this fuctionality exists via RSpec, but the bin/dev/test script currently assumes that you want to run the Rails and JavaScript test suites - IE test the whole application.

In a docker development environment, the test are run using the app
service - IE the use the same "image" as the running application - via
`bin/dev/test`. This service is no longer needed.
@indiebrain indiebrain self-assigned this Sep 25, 2020
@indiebrain indiebrain linked an issue Sep 25, 2020 that may be closed by this pull request
Copy link
Collaborator

@maebeale maebeale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

THANKS for ALLLLL this Docker work!!!!!

@indiebrain
Copy link
Collaborator Author

My pleasure, friend!

@indiebrain indiebrain merged commit 732f16d into main Sep 25, 2020
@indiebrain indiebrain deleted the remove-unused-docker-test-service branch September 25, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove development Docker test service.
2 participants