Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional asdf-vm support and development Makefile #703

Merged
merged 3 commits into from
Sep 19, 2020
Merged

Add optional asdf-vm support and development Makefile #703

merged 3 commits into from
Sep 19, 2020

Conversation

thestephenmarshall
Copy link
Collaborator

@thestephenmarshall thestephenmarshall commented Sep 17, 2020

asdf-vm Version Manager

When it comes to managing various versions of your tools like ruby and node, asdf-vm is an excellent version manager, attempting to cover all needs. I added the very basic .tool-versions file based on the mutual-aid specified versions of ruby, yarn and nodejs. If a contributor is using asdf, they can now make use of their same familiar version manager! 🥳

Docker Startup

Looking through the repo, I found that startup might be enhanced a little by adding a Makefile so that now starting the app in Docker is just make start (etc.). This could most definitely be expanded upon as development continues.

@thestephenmarshall thestephenmarshall marked this pull request as ready for review September 18, 2020 20:55
Copy link
Collaborator

@solebared solebared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks! 🙌🏾

@solebared solebared merged commit c2476d8 into rubyforgood:main Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants