Update docker config #700
Merged
Update docker config #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're missing some configs from `docker-development` environment, which causes a launch to fail.
Mount the application: This loads the application into the running docker image, allowing the running image to do the expected rails development environment thing of seeing your code changes. Run as the current user: this (attempts) to prevent files owned by root from being left on the filesystem. cache mounts: these will keep installed gems and node modules avavilable, so we don't have to grab and reinstall on every rebuild.
solebared
approved these changes
Sep 13, 2020
| depends_on: | ||
| - db | ||
| environment: | ||
| <<: *x-shared-postgres-environment | ||
| <<: *x-email-defaults | ||
| RAILS_ENV: docker-development | ||
| RAILS_ENV: development |
There was a problem hiding this comment.
Such a small diff causing much loss of hair!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docker config.
Attempt to streamline the development config, and the test-run; there are a few things that we can do to clear up the structure going forward, but ... at least this should work