Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker buildfile #685

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Fix docker buildfile #685

merged 1 commit into from
Sep 6, 2020

Commits on Sep 6, 2020

  1. Fix docker buildfile

    Was resulting in an error when attempting to run the build:
      app_1    | /usr/local/bundle/gems/thor-1.0.1/lib/thor/parser/arguments.rb:133:in `parse_numeric': Expected numeric value for '--port'; got "${APP_PORT}" (Thor::MalformattedArgumentError)
    
    There are two things that aren't quite set up right here:
    
    The build arg was not in scope -- used args need to be _below_ the
    `FROM` statement to be accessible.
    
    CMD appears to not allow variable expansion, because it is processed at
    runtime rather than build time.  Instead, we can export the `PORT`
    envar, which will be picked up by `config/puma.rb` when starting rails.
    cflipse committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    1d4d084 View commit details
    Browse the repository at this point in the history