Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tags to the HtmlSanitizer allow list #683

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Conversation

viamin
Copy link
Contributor

@viamin viamin commented Sep 5, 2020

Add b, h{1,2,3,4,5,6}, and span to allowed tags in the HTMLSanitizer model
Also add a spec file for this (not all methods and allowed attributes are tested)

Addresses #663

the HTMLSanitizer model
Also add a spec file for this (not all methods and
whitelisted attributes are present)

Addresses #663
Copy link
Collaborator

@solebared solebared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Appreciate the solid spec as well!

@viamin viamin merged commit 714e96d into main Sep 5, 2020
@viamin viamin deleted the sanitation_rules branch September 5, 2020 19:39
@solebared solebared linked an issue Sep 5, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax sanitization rules so users can do basic things
2 participants