Further readme edits #679
Merged
Further readme edits #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flows nicely into Contribute from the Ruby for Good section, which then flows nicely into Get involved locally.
maebeale
reviewed
Sep 4, 2020
maebeale
reviewed
Sep 4, 2020
maebeale
reviewed
Sep 4, 2020
maebeale
reviewed
Sep 4, 2020
maebeale
reviewed
Sep 4, 2020
|
The changes are great!! Looks and flows perfectly :)
When I was testing links I found the below. I wasn't sure about if or how
to fix.
- in "Contribute" the "this guide" link isn't working
- error message for "Glossary of Terms" and "in code"
- error message for "DEPLOYMENT.md" link
- did we want Customization (WIP) under "More guides and documentation"
to link to something?
- error message for "browse some of our earliest notes" under "Who we
are"
Ginger Albertson
www.linkedin.com/in/gingeralbertson
+1 917 553 9303
…On Fri, Sep 4, 2020 at 6:35 PM lasitha ***@***.***> wrote:
Merged #679 <#679> into
main.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#679 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMNM7CDLFJTGWDRHANBYVCTSEFTT7ANCNFSM4QZQFD7Q>
.
|
Thank you for unearthing these! Fixing.
I think this is a placeholder for future documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages below for a list of the high level changes.
Probably also easier to review the commits separately.
Though, TBH, an even better way is probably to click around the branch tree itself:
https://github.com/rubyforgood/mutual-aid/tree/further-readme-edits.