Migrate multi listing submissions #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solebared
force-pushed
the
migrate-multi-listing-submissions
branch
from
378a3e1
to
af063ec
Compare
|
Force pushed with a simpler TagSplitter algorithm, see af063ec. |
Co-authored-by: Mae Beale <maebeale@users.noreply.github.com> Co-authored-by: h-m-m <howard.m.miller@gmail.com>
Co-authored-by: exbinary <exbinary@gmail.com>
See specs for details.
solebared
force-pushed
the
migrate-multi-listing-submissions
branch
from
af063ec
to
c0a8b34
Compare
maebeale
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got complicated when we started to consider sub-categories!
See af063ec for my attempt to deal with them. I'm not sure how well the code speaks for itself; happy to get on a call if that would be easier/better.
The
one_time:split_listingsrake task should be idempotent on repeated runs, though it will always have to pull and examine any listings with sub-categories (since the query looks for any listing with multiple tags). I formatted theputsoutput to be csv compatible with 3 columns:#- listing being processed,-listing after processing,+newly created listings),Will definitely need some 👀 to verify my specs/logic and do some more testing.