Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom form questions #597

Merged
merged 7 commits into from
Jul 25, 2020
Merged

Custom form questions #597

merged 7 commits into from
Jul 25, 2020

Conversation

maebeale
Copy link
Collaborator

@maebeale maebeale commented Jul 25, 2020 •
edited
Loading

Allow users to add CustomFormQuestions to Forms (and answers stored in db as SubmissionResponses)

  • Currently only handles adding/storing 'string' questions. Still need to add support for boolean, date, etc, as well as support option lists so admins can provide data to populate a dropdown rather than having only text inputs.
  • Tests re re updating a Submission were failing, and we've marked them as pending since we don't currently have that feature deployed anyway

solebared and others added 5 commits July 24, 2020 15:50
@solebared @maebeale
Serialize Form with questions in asks/offers
efe0c7f 
Not used yet. Also renames Form.form_questions -> questions.

Co-authored-by: maebeale <maebeale@gmail.com>
@solebared
Render custom questions on Ask, Offer forms
23b8f67 
For now, does not take question type into account, just renders all of
them as string fields. Also doesn't render the question hint_text.
@maebeale
WIP: create SubmissionResponses upon SubmissionForm create
61d68a2
@maebeale
Comment out Submission update bc there's something wrong w the way we…
45f4baa 
…'re creating SubmissionResponses
@maebeale
Add changelog note
7062857
@maebeale maebeale merged commit 66242aa into master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maebeale @solebared