Merge pull request #792 from yez/main

Add Pagination for People

Gemfile

@@ -27,6 +27,7 @@ gem 'devise'
 gem 'faker' # need this in prod for demo seeds to work
 gem 'jbuilder', '~> 2.7'
 gem 'mobility', '~> 0.8.9'
+gem 'pagy'
 gem 'pg', '>= 0.18', '< 2.0'
 gem 'puma', '~> 5.0'
 gem 'rack-timeout'

Gemfile.lock

@@ -136,6 +136,7 @@ GEM
     nokogiri (1.10.10)
       mini_portile2 (~> 2.4.0)
     orm_adapter (0.5.0)
+    pagy (3.8.3)
     pg (1.2.3)
     pry (0.13.0)
       coderay (~> 1.1)
@@ -276,6 +277,7 @@ DEPENDENCIES
   jbuilder (~> 2.7)
   listen (>= 3.0.5, < 3.2)
   mobility (~> 0.8.9)
+  pagy
   pg (>= 0.18, < 2.0)
   pry
   pry-byebug

app/controllers/concerns/pagination.rb

@@ -0,0 +1,10 @@
+module Pagination
+  extend ActiveSupport::Concern
+
+  include Pagy::Frontend
+  include Pagy::Backend
+
+  included do
+    helper_method :pagy_bulma_nav
+  end
+end

app/controllers/people_controller.rb

@@ -1,9 +1,13 @@
 class PeopleController < ApplicationController
   before_action :set_person, only: [:show, :edit, :update, :destroy]
 
+  include Pagination
+
   def index
-    @people = Person.includes(:user, :preferred_contact_method, :location, :service_area).
-                     references(:user, :preferred_contact_method, :location, :service_area)
+    @pagy, @people = pagy(
+      Person.includes(:user, :preferred_contact_method, :location, :service_area).
+             references(:user, :preferred_contact_method, :location, :service_area)
+    )
   end
 
   def show

app/views/people/index.html.erb

@@ -33,5 +33,14 @@
         <td><%= edit_button(person.user, "", "fa fa-user-edit") if person.user_id %></td>
       </tr>
     <% end %>
+    <% if @pagy.pages > 1 %>
+      <tr>
+        <td></td>
+        <td></td>
+        <td colspan=2>
+          <%= pagy_bulma_nav(@pagy).html_safe %>
+        </td>
+      </tr>
+    <% end %>
   </tbody>
 </table>

config/initializers/pagy.rb

@@ -0,0 +1 @@
+require 'pagy/extras/bulma'

spec/requests/people_spec.rb

@@ -0,0 +1,22 @@
+require 'rails_helper'
+
+describe '/people', type: :request do
+  describe 'GET /index' do
+    let!(:people) { create_list(:person, 40) }
+
+    before do
+      sign_in create(:user)
+    end
+
+    it 'renders a successful response' do
+      get people_url
+      expect(response).to be_successful
+    end
+
+    it 'paginates results' do
+      get people_url
+      people_links = response.body.scan %r{href="/people/\d+/.+"}
+      expect(people_links.size).to eq Pagy::VARS[:items]
+    end
+  end
+end