Uses keyword args for create person from P2P params method

app/controllers/claims_controller.rb

@@ -13,7 +13,11 @@ def create
 
     contribution = Listing.find(params[:contribution_id])
     ActiveRecord::Base.transaction do
-      Person.create_from_peer_to_peer_params!(current_user, peer_to_peer_match_params) if current_user.person.blank?
+      if current_user.person.blank?
+        Person.create_from_peer_to_peer_params!(current_user, name: peer_to_peer_match_params[:peer_alias],
+                                                preferred_contact_method_id: peer_to_peer_match_params[:preferred_contact_method_id],
+                                                contact_info: peer_to_peer_match_params[:preferred_contact_details])
+      end
       Match.create_match_for_contribution!(contribution, current_user)
       contribution.matched!
     end

app/models/match.rb

@@ -41,6 +41,7 @@ def self.follow_up_status(follow_up_status)
     result
   end
 
+  # FIXME: extract into an interactor
   def self.create_match_for_contribution!(contribution, current_user)
     match_params = if contribution.ask?
                       { receiver: contribution, provider: create_offer_for_ask!(contribution, current_user) }

app/models/person.rb

@@ -22,18 +22,17 @@ class Person < ApplicationRecord
 
   validate :preferred_contact_method_present!
 
-  def self.create_from_peer_to_peer_params!(current_user, peer_to_peer_params)
-    contact_method = ContactMethod.find(peer_to_peer_params[:preferred_contact_method_id])
-    contact_method_details = if contact_method.name == "Email"
-                               { email: peer_to_peer_params[:preferred_contact_details] }
-                             else
-                               { phone: peer_to_peer_params[:preferred_contact_details] }
-                             end
-
-    person_params = { name: peer_to_peer_params[:peer_alias],
+  # FIXME: extract into an interactor
+  def self.create_from_peer_to_peer_params!(current_user, name:, preferred_contact_method_id:, contact_info:)
+    contact_method = ContactMethod.find(preferred_contact_method_id)
+    person_params = { name: name,
                       preferred_contact_method: contact_method,
                       user: current_user }
-    create!(person_params.merge(contact_method_details))
+
+    contact_method_name = contact_method.name == "Email" ? :email : :phone
+    person_params[contact_method_name] = contact_info
+
+    create!(person_params)
   end
 
   def name_and_email