Issue 5844: Seeder other duties #5903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crements to the other_duties_counter each time and prints statement of how many other duties were created
… OtherDuty.create
gaurijo
requested review from
compwron,
FireLemons,
littleforest and
elasticspoon
as code owners
elasticspoon
requested changes
Jul 10, 2024
There was a problem hiding this comment.
could you add other_duties to
Line 50 in 350963b
db/seeds/db_populator.rb
Outdated
Comment on lines
123
to
126
| @other_duties_counter = + 1 | ||
| } | ||
| end | ||
| puts "Created #{@other_duties_counter} Other Duties." |
There was a problem hiding this comment.
If we add the count to the main seeds.rb file we don't need the puts or the counter.
elasticspoon
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves 5844
What changed, and why?
@create_other_duties_counterattr.initializedequal to0create_other_dutieswas created; iterates through eachVolunteer objectand creates2OtherDutyinstances per volunteerother_dutyis created it, isincremented onto the counter(+= 1)prints how many other duties have been createdby string interpolating the final counterHow is this tested? (please write tests!) 💖💪
Issue does not require tests;
Tested locally in Rails Console using Volunteer and OtherDuty objects + Faker for dummy data.
Screenshots please :)
From the console:
Feelings gif (optional)
_What gif best describes your feeling working on this issue? https://giphy.com/