fix: n+1 issues in case_contacts#index #5868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticspoon
force-pushed
the
fix/n+1-in-case_contacts#index
branch
from
f3c5f55
to
858bc09
Compare
elasticspoon
commented
Jun 28, 2024
| followups.requested.first | ||
| followups.find(&:requested?) |
There was a problem hiding this comment.
We are including followups in the query already, however, the call to .requested forces another query Followups.where(case_id: id, status: 0) because it needs to check the status. Since all the data is already loaded it makes more sense to check that status in ruby rather than making another request.
elasticspoon
requested review from
compwron,
FireLemons and
littleforest
as code owners
schoork
approved these changes
Jun 29, 2024
compwron
approved these changes
Jun 29, 2024
|
|
This was referenced Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CaseContactsController#indexwas our worst page according to scout.This was mainly because we had 2 N+1 queries:
Those have been fixed.