Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates case contact form to use dropdown selector #5867

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

kenny-luong
Copy link
Contributor

@kenny-luong kenny-luong commented Jun 26, 2024

What github issue is this PR for, if any?

Resolves #5776

What changed, and why?

  1. Picker updated to dropdown selector
  2. Names of the assigned volunteers are displayed next to the case ids only for supervisors
  3. Updated various supporting code for specs to use the new dropdown selector

How is this tested? (please write tests!) 💖💪

I updated the specs to use the new dropdown

Screenshots please :)

http://localhost:3000/case_contacts/64/form/details

image

@github-actions github-actions bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code Tests! 🎉💖👏 erb labels Jun 26, 2024
@schoork
Copy link
Collaborator

schoork commented Jun 27, 2024

Commenting for my visibility

Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@compwron compwron merged commit 9893dad into rubyforgood:main Jun 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file erb ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
3 participants