Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper stripping of whitespace from header values #139

Closed
kenballus opened this issue Jul 4, 2024 · 0 comments · Fixed by #141
Closed

Improper stripping of whitespace from header values #139

kenballus opened this issue Jul 4, 2024 · 0 comments · Fixed by #141

Comments

@kenballus
Copy link
Contributor

When WEBrick receives a request with \x0b or \x0c on either side of a header value, it strips those characters off before processing the header. While header values should be whitespace stripped, the RFC is clear that the only whitespace that should be stripped is SP and HTAB.
jeremyevans added a commit to jeremyevans/webrick that referenced this issue Jul 5, 2024
@jeremyevans
Only strip space and horizontal tab in headers
33d2629 
Previously, all whitespace was stripped, but that goes against
the related RFCs.

Fixes ruby#139
jeremyevans added a commit to jeremyevans/webrick that referenced this issue Jul 5, 2024
@jeremyevans
Only strip space and horizontal tab in headers
d7b0a4f 
Previously, all whitespace was stripped, but that goes against
the related RFCs.

Fixes ruby#139
@jeremyevans jeremyevans mentioned this issue Jul 5, 2024
Merged
jeremyevans added a commit to jeremyevans/webrick that referenced this issue Jul 11, 2024
@jeremyevans
Only strip space and horizontal tab in headers
ee801d6 
Previously, all whitespace was stripped, but that goes against
the related RFCs.

Fixes ruby#139
@pajod pajod mentioned this issue Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only strip space and horizontal tab in headers jeremyevans/webrick
1 participant
@kenballus