Make constant resolution strict for Module#include #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby, `include A; include B` tries to include `A::B` if any. TypeProf tried to reproduce this behavior, but it turned out to be difficult to keep it. This change makes constant resolution not respect the inheritance for the arguments of Module#include. TypeProf retried constant resolution whenever its constant scope is changed, including the inheritance is changed. However, this retry mechanism caused infinite loop when there is a constant like `A::A`. `include A` tries to include the outer `A`, which changes the inheritance, so the `include A` is reanalyzed, and then it tries to include the inner `A::A`, which changes the inheritance again, and then it tries to include the outer `A` again, which returns the first state. By this change, `include A` no longer tries to include the inner `A::A`, so it can avoid the infinite loop. This fixes #285
mame
force-pushed
the
change-include-const-resolution
branch
from
0b931c1 to
220cc30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby,
include A; include Btries to includeA::Bif any. TypeProf tried to reproduce this behavior, but it turned out to be difficult to keep it. This change makes constant resolution not respect the inheritance for the arguments of Module#include.TypeProf retried constant resolution whenever its constant scope is changed, including the inheritance is changed. However, this retry mechanism caused infinite loop when there is a constant like
A::A.include Atries to include the outerA, which changes the inheritance, so theinclude Ais reanalyzed, and then it tries to include the innerA::A, which changes the inheritance again, and then it tries to include the outerAagain, which returns the first state.By this change,
include Ano longer tries to include the innerA::A, so it can avoid the infinite loop.This fixes #285