Avoid wrong infinite loop #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeProf caused an infinite loop under the following situation: ``` @A = @b[0] @b = '/' + @A ``` 1. both @A and @b is untyped 2. @b is changed to a String because of the second line (String#+) 3. @A is changed to a String? because of the first line (String#[]) 4. @b is changed to nil because String#+ does not accept String? 5. go to 2 This change fixes the loop by making `String#+` to accept `String?`. TODO: it should emit a warning, but it is a bot complex considering the situation where passing `Integer | String | nil` to the following foo: ``` def foo: (Integer) -> Integer | (String) -> String ``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeProf caused an infinite loop under the following situation:
This change fixes the loop by making
String#+to acceptString?.TODO: it should emit a warning, but it is a bot complex considering the situation where passing
Integer | String | nilto the following foo: