Let service definitions return code ranges scoped to name #162
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
service#definitions with method call returns full code range of def node now, which results to point
def
keyword.IMO, which is not expected behavior, and it supposed to move cursor to the start of the method name. I confirmed rust analyzer, js lsp do the same thing, so proposed behavior is more friendly to end user.
Changes
DefNode
's mid_code_range attr has name token loc, so just return it instead of which could be enough.Ref:
typeprof/lib/typeprof/core/ast/method.rb
Line 117 in 1601d0c
or should we override
code_range
method ofNode
class? 🤔