Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IRB integration #13

Merged
merged 2 commits into from
May 28, 2023
Merged

Fix IRB integration #13

merged 2 commits into from
May 28, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented May 28, 2023

  1. Some of my changes in Improve IRB integration #9 was not necessary and accidentally caused circular require issue. So I'm fixing that in this PR
  2. If the users' IRB version is not suitable for registering commands, the integration should print a warning and return early.

st0012 added 2 commits May 28, 2023 10:31
@st0012
Avoid circular require on irb integration
abd5421 
tracer/irb should always be required by tracer.rb, so it doesn't need to
require tracer.rb itself.
@st0012
Print warning when user's IRB is too old for the integration
8482e0b
@st0012 st0012 added the bug Something isn't working label May 28, 2023
@st0012 st0012 self-assigned this May 28, 2023
@st0012 st0012 merged commit 2ac7b71 into master May 28, 2023
@st0012 st0012 deleted the fix-irb-integration branch May 28, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@st0012 st0012

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@st0012