Specs for StringIO#sysread and StringIO#read_nonblock #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behaviour can be found in StringIO#read_nonblock and StringIO#sysread, but not in StringIO#read.
herwinw
force-pushed
the
stringio_sysread
branch
from
4cbc51b
to
d738189
Compare
|
Added this spec to |
andrykonchin
approved these changes
Oct 14, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking this as a draft for now, since this whole setup is weird. There is a shared spec
:stringio_sysread_length, but this one is only used byStringIO#read_nonblock, not byStringIO#sysread. There is probably some duplication or some missing specs.