Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend specs for IO#pread #1079

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Extend specs for IO#pread #1079

merged 1 commit into from
Sep 27, 2023

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Sep 11, 2023

No description provided.

core/io/pread_spec.rb Outdated Show resolved Hide resolved
core/io/pread_spec.rb Show resolved Hide resolved
core/io/pread_spec.rb Show resolved Hide resolved
core/io/pread_spec.rb Outdated Show resolved Hide resolved
core/io/pread_spec.rb Show resolved Hide resolved
core/io/pread_spec.rb Show resolved Hide resolved
core/io/pread_spec.rb Show resolved Hide resolved
@herwinw herwinw marked this pull request as draft September 25, 2023 14:33
@herwinw herwinw marked this pull request as ready for review September 27, 2023 16:58
@herwinw
Copy link
Member Author

herwinw commented Sep 27, 2023

I believe all comments have been addressed now.

core/io/pread_spec.rb Outdated Show resolved Hide resolved
@andrykonchin
Copy link
Member

Seems good! Could you please squash commits?

@herwinw
Copy link
Member Author

herwinw commented Sep 27, 2023

Consider it squashed

@andrykonchin
Copy link
Member

Thank you!

@andrykonchin andrykonchin merged commit ef91b0e into ruby:master Sep 27, 2023
10 checks passed
@herwinw herwinw deleted the io_pread branch September 27, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants