Add specs for IO#autoclose? and IO#autoclose= #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual behaviour is still untested.
herwinw
force-pushed
the
io_autoclose
branch
from
65b1c82
to
c890fb0
Compare
andrykonchin
approved these changes
Sep 25, 2023
| @io.close | ||
| -> { @io.autoclose = false }.should raise_error(IOError, /closed stream/) | ||
| end | ||
| end |
There was a problem hiding this comment.
Looks good, but it makes sense to have separate test cases for the methods #autoclose= and #autoclose?.
There could also be added the following checks:
nilvalue is treated asfalsein#autoclose=- by default
#autoclose?returnstrue(it's actually describing behaviour of a constructor method)
There was a problem hiding this comment.
Both additional checks have been added
|
Was there any additional feedback on this? I wonder if we can merge? |
|
This wasn't addressed
neither with with changes nor with starting a discussion. I don't insist on the change but I believe it should be a conscious decision that we are intentionally mixing specs of two methods ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the very basic specs, set a value, get a value. The actual behaviour change is not tested, I tried the example of https://ruby-doc.org/3.2.2/IO.html#method-i-autoclose-3D and a couple of variations, and I could not get them to work.