Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use each library version instead of RUBY_VERSION #1047

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Use each library version instead of RUBY_VERSION #1047

merged 3 commits into from
Jul 10, 2023

Conversation

nobu
Copy link
Member

@nobu nobu commented Jul 8, 2023

nobu added 3 commits July 10, 2023 15:21
@nobu
Use each library version instead of RUBY_VERSION
604693d 
Fixes ruby#1046
https://bugs.ruby-lang.org/issues/19762
@nobu
Remove old guards for before 3.0
ddac676 
- logger 1.4.2 since ruby 2.7.0
- matrix 0.3.1 since ruby 3.0.0
- stringio 3.0.0 since ruby 3.0.0
@nobu
Date::VERSION is defined all supported versions
d2e2663 
It has been defined since date 3.0.3 bundled with ruby 2.7.0.
@nobu
Copy link
Member Author

nobu commented Jul 10, 2023

Added ruby_version_is markers for spec/mspec/tool/remove_old_guards.rb.

eregon
eregon approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eregon eregon merged commit ac1c9c6 into ruby:master Jul 10, 2023
10 checks passed
@nobu nobu deleted the library-version-guards branch July 18, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrongly referring ruby version instead of gem versions
2 participants
@nobu @eregon