Build rubies for ubuntu-24.04 #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
commented
May 14, 2024
| @@ -10,7 +10,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ ubuntu-20.04, ubuntu-22.04, macos-11, macos-arm-oss ] | |||
| os: [ ubuntu-20.04, ubuntu-22.04, ubuntu-24.04, macos-11, macos-arm-oss ] | |||
| ruby: [jruby-9.4.7.0] | |||
There was a problem hiding this comment.
Should I add other rubies in this matrix for this case?
There was a problem hiding this comment.
I typically do it with 1 commit per major.minor, you can see that in existing commits.
IIRC there is some script to easily get such list in this repo or maybe in setup-ruby.
Unfortunately this procedure is not very friendly for PRs.
You could update this one to build all 3.3 releases though, only on 24.04 and if: false on the jruby job below
|
I started the builds with 208503a |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a preparation part of ruby/setup-ruby#595
But please close this PR if the automated bot covers these OS updates. 🙇♂️