Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced RDoc for Element #61

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Enhanced RDoc for Element #61

merged 3 commits into from
Mar 1, 2021

Conversation

BurdetteLamar
Copy link
Member

@BurdetteLamar BurdetteLamar commented Feb 19, 2021 •
edited
Loading

Marking this as a draft b/c it has a couple of TODOs that need review and resolution.

Revised methods:

  • []
  • attribute
  • has_attributes?
  • add_attribute
  • add_attributes
  • delete_attribute
  • cdatas
  • comments
  • instructions
  • texts

@BurdetteLamar BurdetteLamar marked this pull request as draft February 19, 2021 18:28
@BurdetteLamar BurdetteLamar requested a review from kou February 19, 2021 18:30
kou
kou reviewed Feb 19, 2021
View reviewed changes
lib/rexml/element.rb Outdated Show resolved Hide resolved
kou
kou reviewed Feb 19, 2021
View reviewed changes
lib/rexml/element.rb Outdated Show resolved Hide resolved
@BurdetteLamar BurdetteLamar requested a review from kou February 21, 2021 00:32
@kou
Copy link
Member

kou commented Feb 21, 2021

Please wait for a few days...

@BurdetteLamar
Copy link
Member Author

Happy to wait, thanks.

@BurdetteLamar
Copy link
Member Author

@kou , do you expect to review this week?

kou
kou reviewed Mar 1, 2021
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late response...

lib/rexml/element.rb Outdated Show resolved Hide resolved
@BurdetteLamar
Copy link
Member Author

Sorry for my late response...

NP, my friend. We're all busy.

@BurdetteLamar BurdetteLamar marked this pull request as ready for review March 1, 2021 21:10
@BurdetteLamar BurdetteLamar requested a review from kou March 1, 2021 21:11
@kou kou merged commit e23a00b into ruby:master Mar 1, 2021
@kou
Copy link
Member

kou commented Mar 1, 2021

Thanks!

@BurdetteLamar
Copy link
Member Author

Thanks!

Is there someplace where the doc for rexml/master is built out?

@kou
Copy link
Member

kou commented Mar 1, 2021

https://ruby.github.io/rexml/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou Awaiting requested review from kou

Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BurdetteLamar @kou