Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding method Elements#parent #52

Merged
merged 4 commits into from
Feb 10, 2021
Merged

Adding method Elements#parent #52

merged 4 commits into from
Feb 10, 2021

Conversation

BurdetteLamar
Copy link
Member

@BurdetteLamar BurdetteLamar commented Feb 9, 2021

This is mainly to establish the concept of base element, and to be able to retrieve the element elsewhere in the example code.

Next, I'll modify one or two remarks in the existing doc for Elements, then proceed with more RDoc for the class.

@BurdetteLamar BurdetteLamar requested a review from kou February 9, 2021 17:12
@BurdetteLamar
Copy link
Member Author

@kou, I have fouled up these PRs. I thought the earlier one was already merged. Let me know if you want these closed and re-pushed cleanly.

@kou
Copy link
Member

kou commented Feb 10, 2021

Elements#parent is better for consistency.
We have Child#parent.

@BurdetteLamar
Copy link
Member Author

Elements#parent is better for consistency.
We have Child#parent.

Fixed.

@kou
Copy link
Member

kou commented Feb 10, 2021

Could you also update document?

@kou kou changed the title Adding method Elements#base_element Adding method Elements#parent Feb 10, 2021
@BurdetteLamar
Copy link
Member Author

Could you also update document?

Done.

@BurdetteLamar
Copy link
Member Author

@kou, I think I have this cleaned up now.

@kou kou merged commit 3ed5d39 into ruby:master Feb 10, 2021
@kou
Copy link
Member

kou commented Feb 10, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants