Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced RDoc for Document #47

Merged
merged 3 commits into from
Feb 7, 2021
Merged

Enhanced RDoc for Document #47

merged 3 commits into from
Feb 7, 2021

Conversation

BurdetteLamar
Copy link
Member

Revises prefatory material, and methods:

  • new
  • node_type
  • clone
  • expanded_name
  • add

Note well: When I run this through rdoc, the call-seq for method expanded_name, and its aliased method name, does not show up. I have no theory that explains that.

@BurdetteLamar BurdetteLamar requested a review from kou February 6, 2021 16:18
@BurdetteLamar BurdetteLamar marked this pull request as draft February 6, 2021 16:18
@BurdetteLamar
Copy link
Member Author

@kou, did you see this one? I left it as a draft b/c it has a problem with a call-seq.

@kou
Copy link
Member

kou commented Feb 6, 2021

It seems that the expanded_name and name problem is a bug of RDoc. Could you report it to RDoc?
It seems that the name method name may be related.

@BurdetteLamar
Copy link
Member Author

A workaround for the rdoc bug is to omit the call-seq for expanded_name, which is now done here.

I'll have to study how to correctly submit a bug for RDoc.

@BurdetteLamar BurdetteLamar marked this pull request as ready for review February 6, 2021 23:17
@BurdetteLamar
Copy link
Member Author

@kou, now ready for review.

@BurdetteLamar
Copy link
Member Author

@kou said:

It seems that the expanded_name and name problem is a bug of RDoc. Could you report it to RDoc?
It seems that the name method name may be related.

ruby/rdoc#792

@BurdetteLamar
Copy link
Member Author

Restored the call-seq for Document#expanded_name.

@kou kou merged commit 2d50558 into ruby:master Feb 7, 2021
@kou
Copy link
Member

kou commented Feb 7, 2021

Thanks!

@BurdetteLamar BurdetteLamar deleted the document branch February 7, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants