Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization of ATTLIST is incorrect #234

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Fix serialization of ATTLIST is incorrect #234

merged 5 commits into from
Jan 20, 2025

Conversation

OlofKalufs
Copy link
Contributor

@OlofKalufs OlofKalufs commented Jan 17, 2025 •
edited by naitoh
Loading

GitHub: fix #233

Changed so that "<!ATTLIST" is added to AttDecl contents - simliar to how it already was with "<!ENTITY"
Updated a test case to test for this

@naitoh
Copy link
Contributor

naitoh commented Jan 18, 2025

Thanks.
4de910f is a different issue than #233, could you please separate the PR?

@OlofKalufs
Copy link
Contributor Author

Sure, just wanted to make the build go through but now I reverted that commit

@OlofKalufs
Copy link
Contributor Author

Created another PR for the Ruby 3.5+ problem: #235

@naitoh naitoh changed the title Bugfix/#233 serialization of attlist is incorrect Fix serialization of ATTLIST is incorrect Jan 20, 2025
@naitoh naitoh merged commit 107e273 into ruby:master Jan 20, 2025
67 checks passed
@naitoh
Copy link
Contributor

naitoh commented Jan 20, 2025

Thanks, @OlofKalufs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialization of ATTLIST is incorrect
2 participants
@OlofKalufs @naitoh