Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IOSource#readline for @pending_buffer #215

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

naitoh
Copy link
Contributor

@naitoh naitoh commented Oct 18, 2024

Why?

Fixed a problem that @pending_buffer is not processed when IOError occurs in @source.readline although @pending_buffer exists when reading XML file.

## Why?
Fixed a problem that `@pending_buffer` is not processed when `IOError` occurs in `@source.readline` although `@pending_buffer` exists when reading XML file.
@naitoh naitoh marked this pull request as ready for review October 18, 2024 23:52
@kou kou merged commit cf0fb9c into ruby:master Oct 19, 2024
60 of 61 checks passed
@kou
Copy link
Member

kou commented Oct 19, 2024

Thanks.

@naitoh naitoh deleted the fix_readline branch October 19, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants