Fix a bug that a large XML can't be parsed #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Jun 20, 2024
naitoh
force-pushed
the
drop_parsed_content
branch
from
70bce7e
to
57fa969
Compare
kou
reviewed
Jun 21, 2024
test/test_baseparser.rb
Outdated
There was a problem hiding this comment.
Could you move this to test/parser/test_base_parser.rb?
test/test_baseparser.rb
Outdated
|
|
||
| module REXMLTests | ||
| class BaseParserTester < Test::Unit::TestCase | ||
| include REXML |
There was a problem hiding this comment.
This is needless.
Suggested change
| include REXML |
test/test_baseparser.rb
Outdated
| parser = REXML::Parsers::BaseParser.new(xml) | ||
| while parser.has_next? | ||
| parser.pull | ||
| assert_compare REXML::Source::SCANNER_RESET_SIZE + N_STRING.size, ">", parser.position |
There was a problem hiding this comment.
!!! Can we access SCANNER_REST_SIZE via REXML::Source even when we use private_constant!?
There was a problem hiding this comment.
Yes.
20| require 'debug'
21| def test_parse_large_xml
22| xml = build_xml(N_ELEMENTS)
23| parser = REXML::Parsers::BaseParser.new(xml)
=> 24| debugger
25| while parser.has_next?
26| parser.pull
27| assert_compare REXML::Source::SCANNER_RESET_SIZE + N_STRING.size, ">", parser.position
28| end
=>#0 REXMLTests::BaseParserTester#test_parse_large_xml at ~/ghq/github.com/naitoh/rexml/test/parser/test_base.rb:24
#1 Test::Unit::TestCase#run_test at ~/.rbenv/versions/3.3.2/lib/ruby/gems/3.3.0/gems/test-unit-3.6.1/lib/test/unit/testcase.rb:871
# and 28 frames (use `bt' command for all frames)
(ruby) puts REXML::Source::SCANNER_RESET_SIZE
100000
nil
There was a problem hiding this comment.
Oh... It seems that we should remove include Private (in a separated PR)...
naitoh
force-pushed
the
drop_parsed_content
branch
from
57fa969
to
71a4f82
Compare
…exceeds a certain size, have it removed. See: ruby#150 --------- Co-authored-by: Sutou Kouhei <kou@clear-code.com>
naitoh
force-pushed
the
drop_parsed_content
branch
from
71a4f82
to
758b6b4
Compare
kou
changed the title
|
Thanks. |
naitoh
added a commit
to naitoh/rexml
that referenced
this pull request
Jun 22, 2024
kou
pushed a commit
that referenced
this pull request
Jun 22, 2024
Included constants are not private. So private constants in private module aren't private. See also: #154 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: fix GH-150
If a parsed XML is later than
2 ** 31 - 1, we can't parse it. BecauseStringScanners position is stored asint. We can avoid the restriction by dropping large parsed content.