Use loop instead of recursive call for Element#root

It's for performance and avoiding stack level too deep.
ruby · Aug 17, 2024 · 6422fa3 · 6422fa3
1 parent 790ad5c
commit 6422fa3
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/rexml/element.rb b/lib/rexml/element.rb
@@ -441,9 +441,14 @@ def root_node
     # Related: #root_node, #document.
     #
     def root
-      return elements[1] if self.kind_of? Document
-      return self if parent.kind_of? Document or parent.nil?
-      return parent.root
+      target = self
+      while target
+        return target.elements[1] if target.kind_of? Document
+        parent = target.parent
+        return target if parent.kind_of? Document or parent.nil?
+        target = parent
+      end
+      nil
     end
 
     # :call-seq: