Fix redisplay/insert_text called from pre_input_hook #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Sep 3, 2024
lib/reline.rb
Outdated
| def self.insert_text(*args, &block) | ||
| line_editor.insert_text(*args, &block) | ||
| def self.insert_text(text) | ||
| line_editor.insert_pasted_text(text) |
There was a problem hiding this comment.
Should we address the difference in naming in the future?
Also, could stop taking a block be a breaking change to some users? (I didn't find such usage with either Reline.insert_text or Readline.insert_text during a quick search on GH tho)
There was a problem hiding this comment.
It won't be a breaking change. line_editor.insert_text(text) only accepts one String argument.
Passing a block to a method that does not use a block does not raise any error.
naming
Nice catch, I renamed it to insert_multiline_text
It is now used from Reline.insert_text which is not inserting pasted text
st0012
approved these changes
Sep 3, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Sep 3, 2024
(ruby/reline#742) * Fix redisplay/insert_text called from pre_input_hook * Rename insert_pasted_text to insert_multiline_text It is now used from Reline.insert_text which is not inserting pasted text ruby/reline@694a540939
yogo1212
pushed a commit
to yogo1212/ruby
that referenced
this pull request
Sep 4, 2024
(ruby/reline#742) * Fix redisplay/insert_text called from pre_input_hook * Rename insert_pasted_text to insert_multiline_text It is now used from Reline.insert_text which is not inserting pasted text ruby/reline@694a540939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://bugs.ruby-lang.org/issues/20711
Add test for frequently used pre_input_hook pattern.