Merge pull request #131 from nobu/simplify-loop

Fix a warning and simplify the loop
ruby · Feb 29, 2020 · a6148e6 · a6148e6
2 parents d7cc37c + 4fc5e2a
commit a6148e6
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/download-test_readline.rb b/download-test_readline.rb
@@ -47,13 +47,7 @@ def run
       CONNECTIONS.times do
         connections << Thread.new do
           Net::HTTP.start(URI_GH.host, URI_GH.port, :use_ssl => true,:verify_mode => OpenSSL::SSL::VERIFY_PEER) do |http|
-            done = false
-            loop do
-              break if files.empty?
-              path, dir, file = files.shift
-              # x,y,z = [].shift => x is nil
-              break if path.nil?
-
+            while (path, dir, file = files.shift)
               uri = URI("#{HOST}/#{BASE}/#{path}/#{file}")
               req = Net::HTTP::Get.new uri.request_uri
               http.request req do |res|