Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide hamburger on desktop #1237

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Conversation

sunblaze
Copy link
Contributor

The hamburger menu 👇 doesn't need to show on desktop where there's enough room to always show the sidebar.
Screenshot 2024-12-13 at 1 40 17 PM

Here's what it looks like on desktop without:
Screenshot 2024-12-13 at 1 38 05 PM

Dependant on this PR otherwise iPad Pros won't show the navigation.

@st0012 st0012 added the bug label Dec 15, 2024
@st0012 st0012 force-pushed the hide-hamburger-on-desktop branch from 81a8778 to de48f06 Compare December 15, 2024 13:25
@st0012 st0012 merged commit c6193bf into ruby:master Dec 15, 2024
22 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Dec 15, 2024
(ruby/rdoc#1237)

* Clean up the duplicate definitions and unnecessary print styling

* Hides the navigation toggle when there's enough room to always display the navigation

* Update lib/rdoc/generator/template/darkfish/css/rdoc.css

---------

ruby/rdoc@c6193bf1e2

Co-authored-by: Stan Lo <stan001212@gmail.com>
@sunblaze sunblaze deleted the hide-hamburger-on-desktop branch December 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants