Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make methods and attributes linkable #1189

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Make methods and attributes linkable #1189

merged 2 commits into from
Oct 10, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Oct 10, 2024 •
edited
Loading

  1. Use the same highlighting color for headers (align with the change in Improve method source toggling #1176)
  2. Make methods and attributes linkable
    • Because methods were already clickable (to toggle source), I added pilcrow to it when hovered to hint that its behaviour has changed as RDoc has been using pilcrow for header links too, like:
      image
Screen.Recording.2024-10-10.at.13.32.51.mov

@st0012
Copy link
Member Author

st0012 commented Oct 10, 2024

@nobu Thank you for the prompt review!

@st0012 st0012 merged commit 7757fd9 into master Oct 10, 2024
51 checks passed
@st0012 st0012 deleted the make-content-linkable branch October 10, 2024 16:09
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 10, 2024
@st0012 @matzbot
[ruby/rdoc] Make methods and attributes linkable
a778562 
(ruby/rdoc#1189)

* Use the same color for both class/module and method highlight

* Make methods and attributes linkable

ruby/rdoc@7757fd9fe4
@st0012 st0012 added this to the v6.8.0 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobu nobu nobu approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
v6.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @nobu