Remove forward declarations of local variables #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
remove-fowards-decls
branch
2 times, most recently
from
3033039 to
50aae04
Compare
amomchilov
commented
Dec 6, 2024
| @@ -2731,8 +2706,6 @@ static void parse_use_clauses(parserstate *state, VALUE clauses) { | |||
| range namespace_range = NULL_RANGE; | |||
| VALUE namespace = parse_namespace(state, &namespace_range); | |||
|
|
|||
| range clause_range = namespace_range; | |||
There was a problem hiding this comment.
This value is only used different in the two blocks below, so I split it into two local variables.
amomchilov
force-pushed
the
remove-fowards-decls
branch
from
50aae04 to
f8adfee
Compare
amomchilov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our work to migrate the parser off its dependency on Ruby involves introducing new local variables, and incrementally changing types (e.g one branch if an
ifmight use aVALUE, while another uses a newrbs_node_t).To minimize the diff, I've extracted these 2 commits. While long, they're making two simple changes:
{ }blocks around certaincasebodies, in which our code will need to introduce new local variables.