writer: Preserve empty lines between decls for modules #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruby#146 added preservation empty lines between declarations feature to the classes. This also introduces the same feature to the modules. Before this change, our writer inserts a line to between all declarations. It's a bit difficult to read. Therefore, this increases the readability of the generated RBS files.
tk0miya
force-pushed
the
writer/preserve_empty_lines_for_modules
branch
from
d034d66
to
00e6112
Compare
|
I don't think deleting these line breaks makes sense. 🙏 |
|
For example, the types of ActiveRecord models will become very huge. There are too many blank lines. I know this is not for human, but... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#146 adds preservation empty lines between declarations feature to the classes.
This also introduces the same feature to the modules. Before this change, our writer inserts a line to between all declarations. It's a bit difficult to read. Therefore, this increases the readability of the generated RBS files.