Update Method #1939
Merged
Update Method #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampersand
force-pushed
the
swesterman/24-07-21/Method
branch
2 times, most recently
from
be45340
to
4577dfb
Compare
sampersand
commented
Jul 26, 2024
| @@ -161,7 +168,7 @@ class Method < Object | |||
| # m.call # => "bar" | |||
| # n = m.clone.call # => "bar" | |||
| # | |||
| def clone: () -> Method | |||
| def clone: () -> instance | |||
There was a problem hiding this comment.
clone, like dup, technically return instances, but there's no actual way to test this (you can't create subclasses of Method to call #clone on)
lib/rbs/test/type_check.rb
Outdated
| @@ -80,7 +80,7 @@ def method_call(method_name, method_type, call, errors:) | |||
| # Block is given, but not yielded | |||
| end | |||
| else | |||
| if call.block_given | |||
| if call.block_given && !method_type.type.is_a?(Types::UntypedFunction) | |||
There was a problem hiding this comment.
This ensures that UntypedFunctions in tests can take blocks
| Foo.new.method(:foo_with_args).call(1) | ||
| end | ||
| def test_dup | ||
| omit_if RUBY_VERSION < '3.4' |
There was a problem hiding this comment.
Method#dup was only added in ruby 3.4; should we do an %a{rbs:since:3.4} to the definition? probably not.
sampersand
force-pushed
the
swesterman/24-07-21/Method
branch
2 times, most recently
from
92321e7
to
436fd5a
Compare
sampersand
force-pushed
the
swesterman/24-07-21/Method
branch
from
436fd5a
to
adac328
Compare
It’d done at line 62.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
Method.Nothing too crazy going on here.